Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
I
Imgui
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Silvio Roggentin
Imgui
Commits
6dcb7be3
Commit
6dcb7be3
authored
7 months ago
by
Yan Pujante
Committed by
ocornut
7 months ago
Browse files
Options
Downloads
Patches
Plain Diff
CI: amend build tests for emscripten (#7965)
+ Backends: GLFW: minor preemptive fix.
parent
ac2ad798
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
.github/workflows/build.yml
+15
-1
15 additions, 1 deletion
.github/workflows/build.yml
backends/imgui_impl_glfw.cpp
+2
-0
2 additions, 0 deletions
backends/imgui_impl_glfw.cpp
with
17 additions
and
1 deletion
.github/workflows/build.yml
+
15
−
1
View file @
6dcb7be3
...
...
@@ -527,6 +527,7 @@ jobs:
emsdk-master/emsdk update
emsdk-master/emsdk install latest
emsdk-master/emsdk activate latest
sudo apt-get install build-essential
-
name
:
Build example_sdl2_opengl3 with Emscripten
run
:
|
...
...
@@ -535,13 +536,26 @@ jobs:
popd
make -C examples/example_sdl2_opengl3 -f Makefile.emscripten
-
name
:
Build example_glfw_wgpu
# This build compiles example_glfw_wgpu using Makefile.emscripten and Emscripten GLFW built-in implementation (-sUSE_GLFW=3)
# This ensures 2 things: the make build works, and the GLFW built-in implementation is tested
-
name
:
Build example_glfw_wgpu with Emscripten/Makefile
run
:
|
pushd emsdk-master
source ./emsdk_env.sh
popd
make -C examples/example_glfw_wgpu -f Makefile.emscripten
# This build compiles example_glfw_wgpu using CMakeLists.txt and Emscripten GLFW contrib port (--use-port=contrib.glfw3)
# This ensures 2 things: the CMake build works, and the GLFW contrib port is tested
-
name
:
Build example_glfw_wgpu with Emscripten/CMake
run
:
|
pushd emsdk-master
source ./emsdk_env.sh
popd
emcc -v
emcmake cmake -B build -DCMAKE_BUILD_TYPE=Release examples/example_glfw_wgpu
cmake --build build
Android
:
runs-on
:
ubuntu-24.04
steps
:
...
...
This diff is collapsed.
Click to expand it.
backends/imgui_impl_glfw.cpp
+
2
−
0
View file @
6dcb7be3
...
...
@@ -646,6 +646,7 @@ static bool ImGui_ImplGlfw_Init(GLFWwindow* window, bool install_callbacks, Glfw
// Emscripten: the same application can run on various platforms, so we detect the Apple platform at runtime
// to override io.ConfigMacOSXBehaviors from its default (which is always false in Emscripten).
#ifdef __EMSCRIPTEN__
#if EMSCRIPTEN_USE_PORT_CONTRIB_GLFW3 >= 34020240817
if
(
emscripten
::
glfw3
::
IsRuntimePlatformApple
())
{
...
...
@@ -657,6 +658,7 @@ static bool ImGui_ImplGlfw_Init(GLFWwindow* window, bool install_callbacks, Glfw
// See https://github.com/pongasoft/emscripten-glfw/blob/v3.4.0.20240817/docs/Usage.md#the-problem-of-the-super-key
emscripten
::
glfw3
::
SetSuperPlusKeyTimeouts
(
10
,
10
);
}
#endif
#endif
bd
->
ClientApi
=
client_api
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment